Add merge subcommand (fastforward)#48
Merged
ianthomas23 merged 4 commits intoQuantStack:mainfrom Oct 30, 2025
Merged
Conversation
SandrineP
force-pushed
the
merge_sc
branch
2 times, most recently
from
0b08d8e to
2c7544b
Compare
Member
|
It looks like we need to find a way to run the tests without it picking up the |
ianthomas23
requested changes
Oct 29, 2025
| return res ? res : std::string_view{}; | ||
| } | ||
|
|
||
| annotated_commit_list_wrapper::annotated_commit_list_wrapper(std::vector<annotated_commit_wrapper> annotated_commit_list) |
Member
There was a problem hiding this comment.
Now that we have multiple whatever_list_wrapper classes there is probably a way we can move the generic vector functionality into a single templated class that we inherit from. But that can be future work.
Member
There was a problem hiding this comment.
The new list_wrapper is really nice, thanks!
Member
|
I think that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
mergesubcommand (fastforward)